Skip to content

Update golang.org/x/tools to v0.34.0 for Go 1.25 compatibility #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2025

Conversation

stefanb
Copy link
Contributor

@stefanb stefanb commented Jun 14, 2025

The build error with Go 1.25 manifests as:

go1.25rc1 build ./...
# golang.org/x/tools/internal/tokeninternal
../../../go/pkg/mod/golang.org/x/[email protected]/internal/tokeninternal/tokeninternal.go:64:9: invalid array length -delta * delta (constant -256 of type int64)

updated via

go1.25rc1 get -u golang.org/x/tools
go: downloading golang.org/x/crypto v0.39.0
go: downloading golang.org/x/term v0.32.0
go: upgraded golang.org/x/crypto v0.36.0 => v0.39.0
go: upgraded golang.org/x/mod v0.17.0 => v0.25.0
go: upgraded golang.org/x/net v0.38.0 => v0.41.0
go: upgraded golang.org/x/sync v0.12.0 => v0.15.0
go: upgraded golang.org/x/sys v0.31.0 => v0.33.0
go: upgraded golang.org/x/text v0.23.0 => v0.26.0
go: upgraded golang.org/x/tools v0.21.1-0.20240508182429-e35e4ccd0d2d => v0.34.0

go1.25rc1 mod tidy

Related:

The build error with Go 1.25 manifests as:
go1.25rc1 build ./...
# golang.org/x/tools/internal/tokeninternal
../../../go/pkg/mod/golang.org/x/[email protected]/internal/tokeninternal/tokeninternal.go:64:9: invalid array length -delta * delta (constant -256 of type int64)

updated via
go get -u golang.org/x/tools
go mod tidy

Related:
* Go proposal: golang/go#73205
* Upstream x/tools fix: https://go-review.googlesource.com/c/tools/+/675955
* Problem found in Homebrew/homebrew-core#226636
@kezhenxu94
Copy link
Member

@stefanb thanks!

@kezhenxu94 kezhenxu94 merged commit a62f574 into apache:main Jun 14, 2025
1 check passed
@stefanb stefanb deleted the bump-golang.org/x/tools branch June 14, 2025 08:44
@stefanb
Copy link
Contributor Author

stefanb commented Jun 16, 2025

Please don't forget to make a release sometime before or right after Go 1.25 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants