Support span in error status when http code >= 400, and add trace#Error in toolkit API

[alexwn]

1、add logic when http status code >= 400, set span isError is true by span.Error method
2、add new method trace.Error for user set san isError to true by self

[mrproliu]

Also, please update the CHANGES.md, thanks!

[alexwn]

Also, please update the CHANGES.md, thanks!
Done

[wu-sheng]

@alexwn Are you still working on this?

[alexwn]

@alexwn Are you still working on this?
yes, do you have any question? what else should I do?

[wu-sheng]

No, there isn't anything to ask. I am just checking whether the CI fix has any blocks.

[alexwn]

No, there isn't anything to ask. I am just checking whether the CI fix has any blocks.

Yes, I saw it. I just changed the code and submitted it

[wu-sheng]

Still failing. You may still need to make CI runnable locally, which is much easier to see the error and fix.

[alexwn]

Still failing. You may still need to make CI runnable locally, which is much easier to see the error and fix.

I think it should be true, Should I change the gin plugin code?

[wu-sheng]

If that case is using http component as well, then it is affected by your codes.

[alexwn]

If that case is using http component as well, then it is affected by your codes.

entry span is not affected by my code, exist span is effected by my code. I just change two span's isError=true, exist span passed, entry span failed. So I should only change the exit span' isError=true and leave the entry span original?

[wu-sheng]

If that case is using http component as well, then it is affected by your codes.

entry span is not affected by my code, exist span is effected by my code. I just change two span's isError=true, exist span passed, entry span failed. So I should only change the exit span' isError=true and leave the entry span original?

If you want to make changes to another plugin(gin), then you could make them aligned. It depends on you. Ideally, all HTTP RPC relative plugins should follow your new proposal.

[wu-sheng]

@alexwn This change seems to impact other plugin tests as well, please fix them.

[alexwn]

@alexwn This change seems to impact other plugin tests as well, please fix them.
kratosv2 except.yml data, one segment expect status_code=200, but actual no status_code, this segment's component is mux(5017), I saw the code of plugin(mux), it have logical to set the status_code, I have no idea how to fix it.