feat(add trace profile for go agent) #229
Conversation
| _ "strconv" | ||
| _ "strings" | ||
| _ "sync" | ||
| _ "time" | ||
|
|
There was a problem hiding this comment.
Please keep the empty line, it could help with reading the code.
| _ "github.com/apache/skywalking-go/agent/core/operator" | ||
| _ "github.com/apache/skywalking-go/log" | ||
|
|
There was a problem hiding this comment.
Also here, keep the empty line
| @@ -1,20 +1,29 @@ | |||
| module github.com/apache/skywalking-go | |||
|
|
|||
| go 1.19 | |||
| go 1.24 | |||
There was a problem hiding this comment.
Why does the agent need to update to 1.24? The user may use the older go version and it will break the user dependency.
| toolchain go1.24.4 | ||
|
|
||
| replace ( | ||
| skywalking.apache.org/repo/goapi => ../skywalking-goapi |
There was a problem hiding this comment.
Please update the goapi back to the original version.
|
|
||
| replace ( | ||
| skywalking.apache.org/repo/goapi => ../skywalking-goapi | ||
| ) | ||
|
|
||
| require ( |
There was a problem hiding this comment.
This feature no needs to update the dependency, please roll back. Only goapi should be updated.
| @@ -42,6 +42,7 @@ func CreateEntrySpan(operationName string, extractor Extractor, opts ...SpanOpti | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| //id := span.(AdaptSpan).GetTraceID() | |||
There was a problem hiding this comment.
Please remove the comment line.
| @@ -60,7 +60,8 @@ func middleware() echo.MiddlewareFunc { | |||
| if err != nil { | |||
| return err | |||
| } | |||
|
|
|||
| id := span.TraceID() | |||
| fmt.Println("trace_id:", id) | |||
There was a problem hiding this comment.
The fmt.Println should be remove.
| @@ -41,7 +41,6 @@ func (h *ServerInterceptor) BeforeInvoke(invocation operator.Invocation) error { | |||
| if err != nil { | |||
| return err | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Please keep the empty line.
| @@ -193,7 +193,7 @@ func {{.InitFuncName}}(logger operator.LogOperator) (Reporter, error) { | |||
| return NewDiscardReporter(), nil | |||
| } | |||
| checkIntervalVal := {{.Config.Reporter.CheckInterval.ToGoIntValue "the reporter check interval must be number"}} | |||
| checkInterval := time.Second * time.Duration(checkIntervalVal) | |||
| checkInterval := time.Second * time.Duration(checkIntervalVal) | |||
There was a problem hiding this comment.
What's the difference between this line?
| @@ -235,15 +235,17 @@ func initManager(logger operator.LogOperator, checkInterval time.Duration) (*Con | |||
| const grpcReporterInitFunc = ` | |||
|
|
|||
| func initGRPCReporter(logger operator.LogOperator, | |||
| checkInterval time.Duration, | |||
There was a problem hiding this comment.
Please keep the original format.
No description provided.