Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruby agent docs #763

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Add ruby agent docs #763

merged 2 commits into from
Jan 14, 2025

Conversation

CodePrometheus
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for skywalking-website-preview ready!

Name Link
🔨 Latest commit 86b94d9
🔍 Latest deploy log https://app.netlify.com/sites/skywalking-website-preview/deploys/67867ba1c68b150008ca5962
😎 Deploy Preview https://deploy-preview-763--skywalking-website-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wu-sheng
Copy link
Member

Ruby Agent should follow Client JavaScript, because nginx is very specific for nginx, and others are not a language agent.

@CodePrometheus
Copy link
Contributor Author

Are there any other issues besides the order, does the icon need any adjustments?
Google Chrome 2025-01-14 19 48 00

@wu-sheng
Copy link
Member

Could you make the ruby crystal smaller and follow the same style of official one?

image

Keep the crystal complete and add the moon on the right top?

@CodePrometheus
Copy link
Contributor Author

Could you make the ruby crystal smaller and follow the same style of official one?
Keep the crystal complete and add the moon on the right top?

In fact, I initially wanted to do this, but I tried many SVG conversion tools, and the results were not ideal, I may need to use more professional tools to create it.

@wu-sheng
Copy link
Member

@Fine0830 Do you have tool to do this?

@Fine0830
Copy link
Member

@Fine0830 Do you have tool to do this?

How about this one?

ruby_and_moon

@wu-sheng
Copy link
Member

Could you put the size ratio as same as other logos?

@Fine0830
Copy link
Member

Could you put the size ratio as same as other logos?

https://upload.wikimedia.org/wikipedia/commons/7/73/Ruby_logo.svg I cannot change the original logo size.

@wu-sheng
Copy link
Member

image

All existing logos have moon the same size, same ratio, same place.

@Fine0830
Copy link
Member

Updated

ruby_and_moon

@wu-sheng
Copy link
Member

Yes, it is like this, but how to resize the original one...

@Fine0830
Copy link
Member

This one is smaller.

ruby

@wu-sheng
Copy link
Member

Could you make the ruby crystal smaller and follow the same style of official one?
Keep the crystal complete and add the moon on the right top?

In fact, I initially wanted to do this, but I tried many SVG conversion tools, and the results were not ideal, I may need to use more professional tools to create it.

I am not sure why :(. We may need someone more familiar with SVG.

@wu-sheng
Copy link
Member

Could you adjust the order, then we could merge this version first.

@CodePrometheus
Copy link
Contributor Author

OK, let's merge first. I'll try to further process the image using Photoshop.

@wu-sheng wu-sheng merged commit a9976e3 into apache:master Jan 14, 2025
4 of 5 checks passed
@CodePrometheus CodePrometheus deleted the feat-ruby-agent branch January 15, 2025 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants