Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing dashboard settings in Kubernetes Service #12078

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

mrproliu
Copy link
Contributor

@mrproliu mrproliu commented Apr 8, 2024

In #12018, I lost some template configurations and fixed them in this PR.

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

@mrproliu mrproliu added the bug Something isn't working and you are sure it's a bug! label Apr 8, 2024
@mrproliu mrproliu added this to the 10.0.0 milestone Apr 8, 2024
@mrproliu mrproliu requested a review from wankai123 April 8, 2024 08:53
@@ -2074,7 +2074,52 @@
"layer": "K8S_SERVICE",
"entity": "Service",
"name": "K8S-Service-Service",
"id": "K8S-Service-Service"
"id": "K8S-Service-Service",
"isDefault": true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@songzhendong This is the key config to fix dashboard popup about #12072. That is the same.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@wu-sheng wu-sheng merged commit 8dd8421 into apache:master Apr 8, 2024
149 checks passed
@mrproliu mrproliu deleted the fix-missing-exp branch April 8, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working and you are sure it's a bug!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants