Add ITVersion for helping management the versions in IT #12895
Merged
+106
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wankai123
previously approved these changes
Dec 23, 2024
wu-sheng
reviewed
Dec 23, 2024
| */ | ||
| public class ITVersions { | ||
|
|
||
| static Map<String, String> env = readingEnv("test", "e2e-v2", "script", "env"); |
There was a problem hiding this comment.
Is this work in sub folder? This seems a path to project root, but we could run this IT in maven sub module path, or separately in ide.
Have you verified these cases?
There was a problem hiding this comment.
ITVersions will read the user.dir to get the current working directory, then find the directory where mvnw is located.
wu-sheng
reviewed
Dec 23, 2024
...y-integration-test/src/main/java/org/apache/skywalking/oap/server/library/it/ITVersions.java
Outdated
Show resolved
Hide resolved
wu-sheng
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new IT module to help manage the versions in the IT. When some modules are needed to do IT, this module can be introduced to obtain the version. By default, it will first determine whether there is a configuration with an INTEGRATION_ prefix, if so, it will use that. Otherwise, it will use the default configuration.
CHANGESlog.