SOLR-16996: Update Solr Exporter for Prometheus cli to use commons-cli (

#2602) * Migrate SolrExporter to use commons-cli and remove argparse4j * now trigger bats testing when anything changes in the exporter code base to provide better testing --------- Co-authored-by: Eric Pugh <[email protected]>
apache · Aug 2, 2024 · c30e2d0 · c30e2d0
1 parent 88fa620
commit c30e2d0
Show file tree

Hide file tree

Showing 5 changed files with 178 additions and 168 deletions.
diff --git a/.github/workflows/bin-solr-test.yml b/.github/workflows/bin-solr-test.yml
@@ -10,6 +10,7 @@ on:
       - 'solr/bin/**'
       - 'solr/packaging/**'
       - 'solr/core/src/java/org/apache/solr/cli/**'
+      - 'solr/prometheus-exporter/**'
 
 jobs:
   test:
@@ -47,4 +48,3 @@ jobs:
       with:
         name: logs
         path: solr/packaging/build/test-output
-
diff --git a/solr/prometheus-exporter/build.gradle b/solr/prometheus-exporter/build.gradle
@@ -43,7 +43,7 @@ dependencies {
     exclude group: "com.fasterxml.jackson.core", module: "jackson-databind"
   })
   implementation ('com.fasterxml.jackson.core:jackson-databind')
-  implementation ('net.sourceforge.argparse4j:argparse4j')
+  implementation 'commons-cli:commons-cli'
   implementation ('com.github.ben-manes.caffeine:caffeine') { transitive = false }
   implementation 'org.slf4j:slf4j-api'
   implementation 'commons-codec:commons-codec'