Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-14401][SPARK-1844] Use stock sbt-pom-reader and Maven-style dep resolution #12310

Conversation

JoshRosen
Copy link
Contributor

This patch modifies our SBT build to use a stock version of the sbt-pom-reader plugin, rather than our own custom fork, and modifies our build to use SBT 0.13.8+'s Maven resolver plugin (see https://github.com/sbt/sbt/releases/tag/v0.13.8).

I had to add a dummy dev/pom.xml in order to work around a limitation in the POM reader plugin: sbt/sbt-pom-reader#40

@SparkQA
Copy link

SparkQA commented Apr 11, 2016

Test build #55549 has finished for PR 12310 at commit 923a6e1.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@JoshRosen
Copy link
Contributor Author

java.lang.RuntimeException: Could not resolve previous ABI: org.apache.spark:spark-graphx_2.11:1.6.0
    at scala.sys.package$.error(package.scala:27)
    at com.typesafe.tools.mima.plugin.SbtMima$$anonfun$getPreviousArtifact$1.apply(SbtMima.scala:122)
    at com.typesafe.tools.mima.plugin.SbtMima$$anonfun$getPreviousArtifact$1.apply(SbtMima.scala:122)
    at scala.Option.getOrElse(Option.scala:120)
    at com.typesafe.tools.mima.plugin.SbtMima$.getPreviousArtifact(SbtMima.scala:122)
    at com.typesafe.tools.mima.plugin.MimaPlugin$$anonfun$mimaDefaultSettings$5$$anonfun$apply$4.apply(MimaPlugin.scala:69)
    at com.typesafe.tools.mima.plugin.MimaPlugin$$anonfun$mimaDefaultSettings$5$$anonfun$apply$4.apply(MimaPlugin.scala:68)
    at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244)
    at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244)
    at scala.collection.immutable.Set$Set1.foreach(Set.scala:74)
    at scala.collection.TraversableLike$class.map(TraversableLike.scala:244)
    at scala.collection.AbstractSet.scala$collection$SetLike$$super$map(Set.scala:47)
    at scala.collection.SetLike$class.map(SetLike.scala:93)
    at scala.collection.AbstractSet.map(Set.scala:47)
    at com.typesafe.tools.mima.plugin.MimaPlugin$$anonfun$mimaDefaultSettings$5.apply(MimaPlugin.scala:68)
    at com.typesafe.tools.mima.plugin.MimaPlugin$$anonfun$mimaDefaultSettings$5.apply(MimaPlugin.scala:60)
    at scala.Function1$$anonfun$compose$1.apply(Function1.scala:47)
    at sbt.$tilde$greater$$anonfun$$u2219$1.apply(TypeFunctions.scala:40)
    at sbt.std.Transform$$anon$4.work(System.scala:63)
    at sbt.Execute$$anonfun$submit$1$$anonfun$apply$1.apply(Execute.scala:228)
    at sbt.Execute$$anonfun$submit$1$$anonfun$apply$1.apply(Execute.scala:228)
    at sbt.ErrorHandling$.wideConvert(ErrorHandling.scala:17)
    at sbt.Execute.work(Execute.scala:237)
    at sbt.Execute$$anonfun$submit$1.apply(Execute.scala:228)
    at sbt.Execute$$anonfun$submit$1.apply(Execute.scala:228)
    at sbt.ConcurrentRestrictions$$anon$4$$anonfun$1.apply(ConcurrentRestrictions.scala:159)
    at sbt.CompletionService$$anon$2.call(CompletionService.scala:28)
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
    at java.lang.Thread.run(Thread.java:745)

😦. I wonder if this is a MiMa bug. Let me try rolling back the Maven-style dep resolution line to see if that fixes things.

@SparkQA
Copy link

SparkQA commented Apr 12, 2016

Test build #55556 has finished for PR 12310 at commit ca8de82.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@JoshRosen
Copy link
Contributor Author

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Apr 12, 2016

Test build #55562 has finished for PR 12310 at commit ca8de82.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@JoshRosen
Copy link
Contributor Author

Alright, this is blocked until we fix the handling of test-jar dependencies in the upstream POM reader plugin. Closing for now and will re-open later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants