[SPARK-30572][BUILD] Add a fallback Maven repository #27281
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -257,6 +257,22 @@ | |
| <enabled>false</enabled> | ||
| </snapshots> | ||
| </repository> | ||
| <repository> | ||
| <id>central_without_mirror</id> | ||
| <!-- | ||
| This is used as a fallback when a mirror to `central` fail. | ||
| For example, when we use Google Maven Central in GitHub Action as a mirror of `central`, | ||
| this will be used when Google Maven Central is out of sync due to its late sync cycle. | ||
| --> | ||
|
There was a problem hiding this comment. Oh, I mistakenly thought the maven automatically would do the fallback in the mirror failure case. How about leaving some comments, too, about this behaivour in the script of GitHub Actions? spark/.github/workflows/master.yml Line 69 in 19a1059 |
||
| <name>Maven Repository</name> | ||
| <url>https://repo.maven.apache.org/maven2</url> | ||
| <releases> | ||
| <enabled>true</enabled> | ||
| </releases> | ||
| <snapshots> | ||
| <enabled>false</enabled> | ||
| </snapshots> | ||
| </repository> | ||
| </repositories> | ||
| <pluginRepositories> | ||
| <pluginRepository> | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I get it. At this point though, would it just be easier to declare the Google repo above
centralabove, and not use the mirror settings?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ur, I'm not sure that we can declare
Google Maven Centralas Apache Spark default repo because not everyone welcomeGooglerepo. In Apache Spark, we only use this in GitHub Action. The other build environment, we don't useGoogle Maven Centralat all.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure, @srowen ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, it could be listed second. I don't see a problem with including a mirror as a repository here, as it's just a mirror of central. (We have had in the past, even, vendor-specific repos.) I hope it would have the same effect in improving robustness as anyone running the build would have it look at both repos before failing.