[SPARK-30944][BUILD] Update URL for Google Cloud Storage mirror of Maven Central #27688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshRosen
changed the title
HyukjinKwon
approved these changes
Feb 25, 2020
srowen
approved these changes
Feb 25, 2020
|
Test build #118887 has finished for PR 27688 at commit
|
dongjoon-hyun
approved these changes
Feb 25, 2020
dongjoon-hyun
requested changes
Feb 25, 2020
There was a problem hiding this comment.
Oh, @JoshRosen .
Could you fix the default value of spark.sql.maven.additionalRemoteRepositories in sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala together?
|
@dongjoon-hyun, sorry for missing that! I've updated to change that line as well. |
|
Test build #118890 has finished for PR 27688 at commit
|
HyukjinKwon
pushed a commit
that referenced
this pull request
Feb 25, 2020
…ven Central ### What changes were proposed in this pull request? This PR is a followup to #27307: per https://travis-ci.community/t/maven-builds-that-use-the-gcs-maven-central-mirror-should-update-their-paths/5926, the Google Cloud Storage mirror of Maven Central has updated its URLs: the new paths are updated more frequently. The new paths are listed on https://storage-download.googleapis.com/maven-central/index.html This patch updates our build files to use these new URLs. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Existing build + tests. Closes #27688 from JoshRosen/update-gcs-mirror-url. Authored-by: Josh Rosen <[email protected]> Signed-off-by: HyukjinKwon <[email protected]> (cherry picked from commit f152d2a) Signed-off-by: HyukjinKwon <[email protected]>
HyukjinKwon
pushed a commit
that referenced
this pull request
Feb 25, 2020
…ven Central This PR is a followup to #27307: per https://travis-ci.community/t/maven-builds-that-use-the-gcs-maven-central-mirror-should-update-their-paths/5926, the Google Cloud Storage mirror of Maven Central has updated its URLs: the new paths are updated more frequently. The new paths are listed on https://storage-download.googleapis.com/maven-central/index.html This patch updates our build files to use these new URLs. No. Existing build + tests. Closes #27688 from JoshRosen/update-gcs-mirror-url. Authored-by: Josh Rosen <[email protected]> Signed-off-by: HyukjinKwon <[email protected]>
|
Merged to master, branch-3.0 and branch-2.4. There was a conflict in branch-2.4 about |
|
Thank you all! +1, late LGTM. |
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
…ven Central ### What changes were proposed in this pull request? This PR is a followup to apache#27307: per https://travis-ci.community/t/maven-builds-that-use-the-gcs-maven-central-mirror-should-update-their-paths/5926, the Google Cloud Storage mirror of Maven Central has updated its URLs: the new paths are updated more frequently. The new paths are listed on https://storage-download.googleapis.com/maven-central/index.html This patch updates our build files to use these new URLs. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Existing build + tests. Closes apache#27688 from JoshRosen/update-gcs-mirror-url. Authored-by: Josh Rosen <[email protected]> Signed-off-by: HyukjinKwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a followup to #27307: per https://travis-ci.community/t/maven-builds-that-use-the-gcs-maven-central-mirror-should-update-their-paths/5926, the Google Cloud Storage mirror of Maven Central has updated its URLs: the new paths are updated more frequently. The new paths are listed on https://storage-download.googleapis.com/maven-central/index.html
This patch updates our build files to use these new URLs.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing build + tests.