Log exception on Python runner termination #49890
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are situations, when python worker may throw exceptions that are not covered by any other kind of logging (for example custom implementation/enexpected throw from existing code) In these situations it is hard to debug which exactly issue happened, as there is no stack trace in logs and no actual message from exception. To address this issue exception is added for the logging call (rare exception situation while stopping python worker)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
There are situations, when python worker may throw exceptions that are not covered by any other kind of logging (for example custom implementation/unexpected throw from existing code)
In these situations it is hard to debug which exactly issue happened, as there is no stack trace in logs and no actual message from exception.
To address this issue exception is added for the logging call (rare exception situation while stopping python worker)
Why are the changes needed?
To effectively debug rare situations with worker termination.
Does this PR introduce any user-facing change?
no
How was this patch tested?
no need
Was this patch authored or co-authored using generative AI tooling?
no