[WIP][DO-NOT-MERGE][SPARK-51211][SS] Rename the option of readChangeFeed to readChangeLog in state store reader #49945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g in state store reader
HeartSaVioR
changed the title
|
We are yet to finalize the discussion, sorry, let me make this draft. |
anishshri-db
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to rename the option of readChangeFeed to readChangeLog in state store reader.
Why are the changes needed?
We realized that we did marketing of the feature for checkpointing only the update set as "changelog checkpointing". Since this option is dependent on the feature (when users use RocksDB state store provider, they should use changelog checkpointing to use this option), it'd be better to make the option be tightly related.
Does this PR introduce any user-facing change?
No, it's not released yet.
How was this patch tested?
Existing UTs.
Was this patch authored or co-authored using generative AI tooling?
No.