[SPARK-51214][ML][PYTHON][CONNECT] Don't eagerly remove the cached models for fit_transform
#49948
+116
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Don't eagerly remove the cached models for
fit_transform
:1, still keep the
Delete
ml command protobuf, but no longer call it in__del__
in the python client side;2, build the ml cache with guava CacheBuilder and soft references, and specify the maximum size and time out.
Why are the changes needed?
a common ml pipeline pattern is
fit_transform
:existing implementation eagerly deletes the intermediate model from the ml cache, right after
fit_transform
, and thus causes NPEDoes this PR introduce any user-facing change?
yes
How was this patch tested?
added tests
Was this patch authored or co-authored using generative AI tooling?
no