[SPARK-51216][BUILD] Remove the useless bigtop-dist profile and the related outdated files
#49952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
changed the title
bigtop-dist profilebigtop-dist profile and the related outdated files
LuciferYang
changed the title
bigtop-dist profile and the related outdated filesbigtop-dist profile and the related outdated files
pan3793
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
LGTM, the bigtop profile is useless after BIGTOP-2569 (apache/bigtop@71df9df), which switched to dev/make-distribution.sh to assemble the Spark.
dongjoon-hyun
approved these changes
Feb 14, 2025
|
It looks like the assembly module has not been deleted in parent pom? |
|
@yaooqinn |
|
Merged into master. Thanks @dongjoon-hyun @yaooqinn and @pan3793 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR removes the unused
bigtop-distconfiguration file, related configuration files, and outdatedREADMEfile from theassemblymodule, as Spark now usesdev/make-distribution.shto build the distribution instead of this profile.Why are the changes needed?
Remove the useless
bigtop-distprofile and the related outdated filesDoes this PR introduce any user-facing change?
No
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No