[SPARK-51156][CONNECT][FOLLOWUP] Remove unused private val AUTH_TOKEN_ON_INSECURE_CONN_ERROR_MSG from SparkConnectClient
#50070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
changed the title
private val AUTH_TOKEN_ON_INSECURE_CONN_ERROR_MSG from SparkConnectClientprivate val AUTH_TOKEN_ON_INSECURE_CONN_ERROR_MSG from SparkConnectClient
Contributor
Author
dongjoon-hyun
approved these changes
Feb 24, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @LuciferYang .
Merged to master/4.0.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Feb 24, 2025
…N_ON_INSECURE_CONN_ERROR_MSG` from `SparkConnectClient` ### What changes were proposed in this pull request? This pr aims to remove unused `private val AUTH_TOKEN_ON_INSECURE_CONN_ERROR_MSG` from `SparkConnectClient` because it becomes a useless `private val` declaration after #50006. ### Why are the changes needed? Remove unused `private val`. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes #50070 from LuciferYang/SPARK-51156-FOLLOWUP. Authored-by: yangjie01 <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 9de3b7c) Signed-off-by: Dongjoon Hyun <[email protected]>
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 14, 2025
…N_ON_INSECURE_CONN_ERROR_MSG` from `SparkConnectClient` ### What changes were proposed in this pull request? This pr aims to remove unused `private val AUTH_TOKEN_ON_INSECURE_CONN_ERROR_MSG` from `SparkConnectClient` because it becomes a useless `private val` declaration after apache#50006. ### Why are the changes needed? Remove unused `private val`. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#50070 from LuciferYang/SPARK-51156-FOLLOWUP. Authored-by: yangjie01 <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 1fff139) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr aims to remove unused
private val AUTH_TOKEN_ON_INSECURE_CONN_ERROR_MSGfromSparkConnectClientbecause it becomes a uselessprivate valdeclaration after #50006.Why are the changes needed?
Remove unused
private val.Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Actions
Was this patch authored or co-authored using generative AI tooling?
No