[SPARK-52007] [SQL] Expression IDs shouldn't be present in grouping expressions when using grouping sets #50791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihailoale-db
force-pushed
the
fixgroupingsetsschema
branch
from
5181779 to
5a26cdb
Compare
|
@cloud-fan could you PTAL when you have time (Docker test doesnt seem related)? Thanks |
cloud-fan
approved these changes
May 6, 2025
|
yea the docker test is unrelated, thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In this PR I propose that we change
.toStringtotoPrettySQLwhen constructing grouping expressions inResolveGroupingAnalyticsrule.Why are the changes needed?
Right now following query would pass (
#xand#yare expression IDs generated with every cluster start):select * from values(1,2) group by grouping sets (col1,col2,col1+col2) order by(col1#x + col2#y)``But with next cluster restart, expression IDs would be regenerated and the query would fail. Because of that we need to fix this to disallow this nondeterministic behavior.
Does this PR introduce any user-facing change?
Some queries (and Dataframe programs) are going to fail but they would fail with every cluster restart (as explained above).
How was this patch tested?
Added tests.
Was this patch authored or co-authored using generative AI tooling?
No.