[SPARK-52632][SQL] Pretty display V2 write plan nodes #51332
+9
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
reviewed
Jul 2, 2025
| @@ -67,6 +68,7 @@ private[noop] object NoopBatchWrite extends BatchWrite { | |||
| override def useCommitCoordinator(): Boolean = false | |||
| override def commit(messages: Array[WriterCommitMessage]): Unit = {} | |||
| override def abort(messages: Array[WriterCommitMessage]): Unit = {} | |||
| override def toString: String = "NoopBatchWrite" | |||
There was a problem hiding this comment.
Can we use Utils.getFormattedClassName?
There was a problem hiding this comment.
thanks for suggestion, updated
|
cc @viirya |
viirya
reviewed
Jul 2, 2025
| @@ -367,6 +365,8 @@ trait V2ExistingTableWriteExec extends V2TableWriteExec { | |||
| def refreshCache: () => Unit | |||
| def write: Write | |||
|
|
|||
| override val stringArgs: Iterator[Any] = Iterator(query, write) | |||
There was a problem hiding this comment.
As query is the child of the plan, it won't be shown by argString, I wonder why we need to put it in stringArgs?
There was a problem hiding this comment.
I noticed that, but other existing overrides also include the child, I just follow that.
for example
case class SubqueryExec(...) {
...
override def stringArgs: Iterator[Any] = Iterator(name, child) ++ Iterator(s"[id=#$id]")
...
}
viirya
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Pretty display V2 write plan nodes by overriding
def stringArgs.Why are the changes needed?
Better UX for UI display and
EXPLAINoutputDoes this PR introduce any user-facing change?
Yes, change affects UI display and
EXPLAINoutput for V2 write cases.How was this patch tested?
Use AppendData as an example.
Before
After
Was this patch authored or co-authored using generative AI tooling?
No.