[SPARK-52649][SQL] Trim aliases before matching Sort/Having/Filter expressions in buildAggExprList
#51339
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Trim aliases before matching Sort/Having/Filter expressions with semantically equal expression from the Aggregate below in
buildAggExprList
Why are the changes needed?
For a query like:
Plan after
ResolveReferences
and beforeResolveAggregateFunctions
looks like:Because aggregate list has
Alias(Alias(cast((shiftright(spark_grouping_id#18L, 1) & 1) as tinyint))
expression fromSortOrder
won't get matched as semantically equal and it will result in adding an unnecessaryProject
. By stripping inner aliases from aggregate list (that are going to get removed anyways inCleanupAliases
) we can matchSortOrder
expression and resolve it asgrouping(course)#15
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests
Was this patch authored or co-authored using generative AI tooling?
No