[SPARK-52656][SQL] Fix current_time() #51351
Open
+43
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
changed the title
MaxGekk
commented
Jul 2, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala
Outdated
Show resolved
Hide resolved
MaxGekk
changed the title
MaxGekk
changed the title
|
@cloud-fan @the-sakthi Could you review this bug fix, please. |
|
@dongjoon-hyun @LuciferYang Could you review this PR, please. |
LuciferYang
reviewed
Jul 3, 2025
| * | ||
| * For example, if `p = 3`, we keep millisecond resolution and discard any digits beyond the | ||
| * thousand-microsecond place. So a value like `123456` microseconds (12:34:56.123456) becomes | ||
| * thousand-nanosecond place. So a value like `123456` microseconds (12:34:56.123456) becomes |
There was a problem hiding this comment.
So a value like `123456` microseconds (12:34:56.123456) becomes
* `123000` microseconds (12:34:56.123).
Is it still "microseconds" in this comment? Is that correct?
|
Lgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
After switching of internal representation of TIME values from microseconds to nanoseconds by the PR #51156, the
current_time(p)returns incorrect result. In the PR, I propose to fix two datetime functionstruncateTimeToPrecision()andinstantToNanosOfDay(), and apparently the expressionCurrentTime.Why are the changes needed?
It fixes incorrect behaviour of the
current_time()function.Does this PR introduce any user-facing change?
No, the TIME data type and related functions haven't been released yet.
How was this patch tested?
By running new tests:
and by manual testing:
Was this patch authored or co-authored using generative AI tooling?
No.