Skip to content

[SPARK-52409][SDP] Only use PipelineRunEventBuffer in tests #51352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sryza
Copy link
Contributor

@sryza sryza commented Jul 2, 2025

What changes were proposed in this pull request?

This PR inverts the relationship between event callbacks and PipelineRunEventBuffer.

Prior to this PR:

  • PipelineUpdateContext had a PipelineRunEventBuffer, that all events from the run were written to.
  • This PipelineRunEventBuffer contained an eventCallback val which the Connect backend used to forward events to the client
  • The only code that reads from the buffer is test code

After this PR:

  • PipelineUpdateContext has an eventCallback, which is invoked on all events.
  • The test harness constructs a PipelineRunEventBuffer and passes its addEvent method to the eventCallback

Why are the changes needed?

With the prior code, there was a risk of memory pressure from the event buffer for long-running pipelines.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Existing tests

Was this patch authored or co-authored using generative AI tooling?

No

@sryza
Copy link
Contributor Author

sryza commented Jul 2, 2025

@jonmio – I'm not sure how to add you as a reviewer, but heads up about this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant