[SPARK-53809][SQL]Add canonicalization for DataSourceV2ScanRelation #52529
+126
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yhuang-db , can you please check the test failures? Some of them seems related to your change. |
yhuang-db
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to add doCanonicalize function for DataSourceV2ScanRelation. The implementation is similar to the one implemented in BatchScanExec, because they are both the leafNodes of DSv2 logicalPlan and physicalPlan, respectively.
Why are the changes needed?
Query optimization rules such as MergeScalarSubqueries check if two plans are identical by comparing their canonicalized form. For DSv2, for physical plan, the canonicalization goes down in the child hierarchy to the BatchScanExec, which has a doCanonicalize function; for logical plan, the canonicalization goes down to the DataSourceV2ScanRelation, which, however, does not have a doCanonicalize function. As a result, two logical plans who are semantically identical are not identified.
Does this PR introduce any user-facing change?
No
How was this patch tested?
todo
Was this patch authored or co-authored using generative AI tooling?
No