[SDP] typo hunting and code (re)formatting #52538
Open
+141
−135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @sryza |
jaceklaskowski
changed the title
sryza
reviewed
Oct 9, 2025
There was a problem hiding this comment.
Thanks for the contribution @jaceklaskowski ! There's a bunch of different stuff in here – some of it is code cleanup (no brainer stuff that I can merge immediately) and other bits introduce small behavior changes (changes to logging and CLI output) that could maybe use some light rounds of discussion. Would you be up for separating those into two PRs?
|
How about the current "version" of this PR? Hope you like it, @sryza 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixes typos and cleans up code formatting (that could've been automated, but done manually this time)
Why are the changes needed?
Cleaner code with a fewer typos
Does this PR introduce any user-facing change?
No
How was this patch tested?
Built locally. Waiting for the official build to finish once PR's created.
Was this patch authored or co-authored using generative AI tooling?
No