[WIP][SPARK-53855][SQL] Fix PlanID preservation in ResolveSQLFunctions with UDFs #52546
+14
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uros-db
changed the title
|
@vladimirg-db @mihailoale-db @mihailotim-db @ilicmarkodb @cloud-fan Please review. |
cloud-fan
reviewed
Oct 10, 2025
|
|
||
| test("preserve plan ID in ResolveSQLFunctions with UDF") { | ||
| // Create a simple SQL function / UDF for testing purposes. | ||
| spark.sql("""CREATE OR REPLACE FUNCTION funct(x INT) RETURNS STRING RETURN |
There was a problem hiding this comment.
let's wrap the test with withUserDefinedFunction
cloud-fan
reviewed
Oct 10, 2025
| .sql("SELECT * FROM VALUES (0, 1)") | ||
| .select(expr("funct(col1)").alias("col2")) | ||
| // Now use the UDF in a query that will initiate plan rewrite by ResolveSQLFunctions. | ||
| df.groupBy("col2").agg(count("*")).explain(true) |
uros-db
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Properly preserve
Projectnode tags (including the plan ID) in plan rewrites under theResolveSQLFunctionsanalyzer rule.Why are the changes needed?
Fix an issue with incorrectly dropped plan IDs, causing query failures (
CANNOT_RESOLVE_DATAFRAME_COLUMN) when using Spark Connect.Does this PR introduce any user-facing change?
Yes, some failing queries will now work properly with Spark Connect.
How was this patch tested?
Added a new test in a Spark Connect scala suite.
Was this patch authored or co-authored using generative AI tooling?
No.