[SPARK-53845] SDP Sinks #52563
Closed
[SPARK-53845] SDP Sinks #52563
+648
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sryza ready for review |
sryza
reviewed
Oct 10, 2025
| identifier: TableIdentifier, | ||
| format: String, | ||
| options: Map[String, String], | ||
| normalizedPath: Option[String], |
There was a problem hiding this comment.
Does a sink need a normalizedPath?
There was a problem hiding this comment.
yeah not needed, removed
sql/pipelines/src/main/scala/org/apache/spark/sql/pipelines/graph/FlowExecution.scala
Outdated
Show resolved
Hide resolved
| override def toString: String = "VIEW" | ||
| } | ||
|
|
||
| private object SinkType extends DatasetType { |
There was a problem hiding this comment.
Sinks aren't datasets. I.e. the hierarchy is something like:
- A table is a dataset
- A view is a dataset
- A dataset is an output
- A sink is an output
There was a problem hiding this comment.
Yeah I think we can just rename DatasetType to OutputType since the usage of this object in assertOutputIdentifierIsUnique does not distinguish between an output and a dataset.
Also renamed error message PIPELINE_DUPLICATE_IDENTIFIERS.DATASET to PIPELINE_DUPLICATE_IDENTIFIERS.OUTPUT since we also need to check for sink duplicate id.
sql/pipelines/src/test/scala/org/apache/spark/sql/pipelines/graph/SystemMetadataSuite.scala
Outdated
Show resolved
Hide resolved
…aph/SystemMetadataSuite.scala Co-authored-by: Sandy Ryza <[email protected]>
sryza
reviewed
Oct 10, 2025
| get_active_graph_element_registry().register_output(table) | ||
|
|
||
|
|
||
| def create_sink( |
There was a problem hiding this comment.
Oops missed this on first pass: this needs docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Create the API and implementation to allow users to define a sink in a SDP pipeline as outlined in the SPIP. A sink is an external location the pipeline can write data to.
Why are the changes needed?
New Feature
Does this PR introduce any user-facing change?
New API for unrelased SDP
How was this patch tested?
New and existing tests to ensure sinks work e2e
Was this patch authored or co-authored using generative AI tooling?
No