ExplodeBase.eval IterableOnce directly on input #52576
Open
+33
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes changing the value returned from
ExplodeBase.evalfromArray[IterableOnce]toIterableOnce[IternalRow].Arrayconverts to anIterableOncewith an implicit conversion. This change proposes directly returning anIterableOnce[InternalRow]object that is a thin wrapper around input.Why are the changes needed?
I wouldn't say they are needed, however the current implementation creates an intermediate array that is populated and then iterated. The creation and population of the array would be eliminated with this PR.
Does this PR introduce any user-facing change?
This PR has no user facing changes.
How was this patch tested?
Github Actions
Was this patch authored or co-authored using generative AI tooling?
The creation of this patch was assisted by Microsoft Copilot. The initial change was made using Agent mode.