[SPARK-53882][CONNECT][SCALA] Always set a sql state in spark connect client #52589
+93
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garlandz-db
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Ensure there exists an error class in every error thrown from spark connect client by providing fallback error classes
Why are the changes needed?
At the moment there are some cases where an errorClass is not thrown. This goes against the goal of promoting a definition for providing a sql state for every exception in better sql error messages.
Does this PR introduce any user-facing change?
Yes. A previous error message that did not throw an error class now does.
How was this patch tested?
Unit testing
Was this patch authored or co-authored using generative AI tooling?