Skip to content
This repository was archived by the owner on Jul 10, 2024. It is now read-only.

Conversation

cdmikechen
Copy link
Contributor

@cdmikechen cdmikechen commented Jan 20, 2022

What is this PR for?

Add a database initialization metadata service with flyway. When users use their own RDS service or database, submarine can automatically initialize the database.
Since no association usage has been found in the server-core/k8s package, only the submarine database has been initialized for the time being, and metastore and mlflow have not been processed.

What type of PR is it?

Feature

Todos

  • - Add DatabaseMetadataService to init database metadata by flyway
  • - Add a test case to init database on h2

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-1168

How should this be tested?

Have added a test case org.apache.submarine.server.database.TestInitDatabaseMetadata

Screenshots (if appropriate)

Questions:

  • Do the license files need updating? No
  • Are there breaking changes for older versions? No
  • Does this need new documentation? No

@codecov
Copy link

codecov bot commented Jul 23, 2023

Codecov Report

Merging #873 (db64bd9) into master (09a7e77) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #873   +/-   ##
=======================================
  Coverage   67.27%   67.27%           
=======================================
  Files         128      128           
  Lines        6224     6224           
=======================================
  Hits         4187     4187           
  Misses       2037     2037           
Flag Coverage Δ
python-integration 54.20% <ø> (ø)
python-unit 48.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant