fix(theming): Fix visual regressions from theming P7 #34237
Merged
+508
−419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… unify the modal taste with the others
…with edit mode support and customizable icon - Supports dynamic titles based on edit mode (add/edit) - Allows passing a custom icon with forced iconSize override - Applies consistent styling and spacing for title and icon - Adds data-test attribute for easier testing - Improves code clarity by handling icon rendering and translation internally
dosubot
bot
added
change:frontend
EnxDev
added
review:draft
and removed
change:frontend
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've completed my review and didn't find any issues.
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/src/features/datasets/DuplicateDatasetModal.tsx | ✅ |
| superset-frontend/src/features/roles/RoleListAddModal.tsx | ✅ |
| superset-frontend/src/components/ModalTitleWithIcon/index.tsx | ✅ |
| superset-frontend/src/features/tags/BulkTagModal.tsx | ✅ |
| superset-frontend/src/features/groups/GroupListModal.tsx | ✅ |
| superset-frontend/packages/superset-ui-core/src/components/UnsavedChangesModal/index.tsx | ✅ |
| superset-frontend/src/pages/UserInfo/index.tsx | ✅ |
| superset-frontend/src/SqlLab/components/SaveQuery/index.tsx | ✅ |
| superset-frontend/src/features/annotationLayers/AnnotationLayerModal.tsx | ✅ |
| superset-frontend/src/features/users/UserListModal.tsx | ✅ |
| superset-frontend/src/features/cssTemplates/CssTemplateModal.tsx | ✅ |
| superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.tsx | ✅ |
| superset-frontend/src/features/tags/TagModal.tsx | ✅ |
| superset-frontend/src/pages/GroupsList/index.tsx | ✅ |
| superset-frontend/src/explore/components/PropertiesModal/index.tsx | ✅ |
| superset-frontend/src/SqlLab/components/SaveDatasetModal/index.tsx | ✅ |
| superset-frontend/src/features/rls/RowLevelSecurityModal.tsx | ✅ |
| superset-frontend/src/explore/components/ControlPanelsContainer.tsx | ✅ |
| superset-frontend/src/dashboard/components/PropertiesModal/index.tsx | ✅ |
| superset-frontend/src/features/databases/UploadDataModel/index.tsx | ✅ |
| superset-frontend/src/features/alerts/AlertReportModal.tsx | ✅ |
| superset-frontend/src/components/Datasource/DatasourceEditor.jsx | ✅ |
| superset-frontend/src/features/databases/DatabaseModal/index.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
…heckStatus is defined
dosubot
bot
added
change:frontend
There was a problem hiding this comment.
I've completed my review and didn't find any issues.
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/packages/superset-ui-core/src/components/DeleteModal/types.ts | ✅ |
| superset-frontend/packages/superset-ui-core/src/components/ConfirmStatusChange/index.tsx | ✅ |
| superset-frontend/packages/superset-ui-core/src/components/DeleteModal/index.tsx | ✅ |
| superset-frontend/src/features/roles/RoleListDuplicateModal.tsx | ✅ |
| superset-frontend/src/features/datasets/DuplicateDatasetModal.tsx | ✅ |
| superset-frontend/packages/superset-ui-core/src/components/Modal/FormModal.tsx | ✅ |
| superset-frontend/src/features/roles/RoleListAddModal.tsx | ✅ |
| superset-frontend/src/features/tags/BulkTagModal.tsx | ✅ |
| superset-frontend/packages/superset-ui-core/src/components/Collapse/CollapseLabelInModal.tsx | ✅ |
| superset-frontend/src/features/groups/GroupListModal.tsx | ✅ |
| superset-frontend/src/components/ModalTitleWithIcon/index.tsx | ✅ |
| superset-frontend/packages/superset-ui-core/src/components/UnsavedChangesModal/index.tsx | ✅ |
| superset-frontend/src/features/roles/RoleListEditModal.tsx | ✅ |
| superset-frontend/src/pages/UserInfo/index.tsx | ✅ |
| superset-frontend/src/SqlLab/components/SaveQuery/index.tsx | ✅ |
| superset-frontend/src/components/Datasource/ChangeDatasourceModal.tsx | ✅ |
| superset-frontend/src/features/annotationLayers/AnnotationLayerModal.tsx | ✅ |
| superset-frontend/src/features/cssTemplates/CssTemplateModal.tsx | ✅ |
| superset-frontend/src/features/users/UserListModal.tsx | ✅ |
| superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.tsx | ✅ |
| superset-frontend/src/features/tags/TagModal.tsx | ✅ |
| superset-frontend/src/pages/GroupsList/index.tsx | ✅ |
| superset-frontend/src/explore/components/PropertiesModal/index.tsx | ✅ |
| superset-frontend/src/SqlLab/components/SaveDatasetModal/index.tsx | ✅ |
| superset-frontend/src/features/rls/RowLevelSecurityModal.tsx | ✅ |
| superset-frontend/src/explore/components/ControlPanelsContainer.tsx | ✅ |
| superset-frontend/src/dashboard/components/PropertiesModal/index.tsx | ✅ |
| superset-frontend/src/features/databases/UploadDataModel/index.tsx | ✅ |
| superset-frontend/src/features/alerts/AlertReportModal.tsx | ✅ |
| superset-frontend/src/components/Datasource/DatasourceEditor.jsx | ✅ |
| superset-frontend/src/features/databases/DatabaseModal/index.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
|
@EnxDev Processing your ephemeral environment request here. Action: up. More information on how to use or configure ephemeral environments |
|
@EnxDev Ephemeral environment spinning up at http://52.34.48.213:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup. |
msyavuz
reviewed
Jul 23, 2025
|
@EnxDev Processing your ephemeral environment request here. Action: up. More information on how to use or configure ephemeral environments |
|
@EnxDev Ephemeral environment spinning up at http://52.42.122.118:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup. |
mistercrunch
approved these changes
Jul 24, 2025
EnxDev
requested review from
sadpandajoe,
eschutho,
rusackas and
betodealmeida
as code owners
EnxDev
force-pushed
the
enxdev/fix/visual-regression-p7
branch
from
fa29c76 to
73566e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes various regressions introduced by the
theming projectand introduces a new reusable component,ModalTitleWithIcon, to standardize the rendering of modal titles across the application.✅ What's Included
🎯 Why
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION