Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.2.x] Backport: Fix ordering Via response header values (#9239) #12087

Open
wants to merge 1 commit into
base: 9.2.x
Choose a base branch
from

Conversation

hnakamur
Copy link
Contributor

@hnakamur hnakamur commented Mar 6, 2025

Backport #9239 to 9.2.x.

Currently, when upstream returns 304 response, the order of Via response header values is wrong.

Expected order: upstream's Via, our Via
Actual order: our Via, upstream's Via

This pull request fixes this.

(cherry picked from commit e34ec50)

When we craft the Via header, the origin's Via should come before our Via headers. Before this patch, the order was reversed. This fixes that.
@hnakamur hnakamur requested a review from zwoop as a code owner March 6, 2025 12:38
@ezelkow1 ezelkow1 requested a review from bneradt March 6, 2025 15:01
@ezelkow1 ezelkow1 added this to the 9.2.10 milestone Mar 6, 2025
@ezelkow1
Copy link
Member

ezelkow1 commented Mar 6, 2025

[approve ci autest 1]

@ezelkow1 ezelkow1 removed the request for review from zwoop March 7, 2025 23:01
@ezelkow1 ezelkow1 added the Backport Marked for backport for an LTS patch release label Mar 7, 2025
@ezelkow1 ezelkow1 requested a review from masaori335 March 7, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport Marked for backport for an LTS patch release
Projects
Status: For Review
Development

Successfully merging this pull request may close these issues.

2 participants