Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add statistic compatibility #382

Merged
merged 4 commits into from
Jan 17, 2025
Merged

Add statistic compatibility #382

merged 4 commits into from
Jan 17, 2025

Conversation

jt2594838
Copy link
Contributor

No description provided.

(cherry picked from commit 03c229d)
(cherry picked from commit c97ec47)
(cherry picked from commit 92a06d1)
(cherry picked from commit 8dd5f1c)
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 76.97842% with 32 lines in your changes missing coverage. Please review.

Project coverage is 64.66%. Comparing base (871cb09) to head (ee50236).

Files with missing lines Patch % Lines
...che/tsfile/read/common/block/column/IntColumn.java 0.00% 15 Missing ⚠️
...e/tsfile/read/common/block/column/FloatColumn.java 0.00% 5 Missing ⚠️
...he/tsfile/read/common/block/column/LongColumn.java 0.00% 5 Missing ⚠️
...ile/file/metadata/statistics/BinaryStatistics.java 90.00% 1 Missing ⚠️
...le/file/metadata/statistics/BooleanStatistics.java 91.66% 1 Missing ⚠️
...ile/file/metadata/statistics/DoubleStatistics.java 94.44% 1 Missing ⚠️
...file/file/metadata/statistics/FloatStatistics.java 94.44% 1 Missing ⚠️
...le/file/metadata/statistics/IntegerStatistics.java 94.44% 1 Missing ⚠️
...sfile/file/metadata/statistics/LongStatistics.java 94.44% 1 Missing ⚠️
...ile/file/metadata/statistics/StringStatistics.java 93.75% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #382      +/-   ##
===========================================
- Coverage    64.66%   64.66%   -0.01%     
===========================================
  Files          541      541              
  Lines        32329    32370      +41     
  Branches      4313     4318       +5     
===========================================
+ Hits         20906    20931      +25     
- Misses       10926    10942      +16     
  Partials       497      497              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Override
protected void mergeStatisticsValue(Statistics<Integer> stats) {
protected void mergeStatisticsValue(Statistics stats) {
IntegerStatistics intStats = (IntegerStatistics) stats;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why didn't modify IntegerStatistics?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No other type can be altered to INT32 so other statistics will not be merged into IntegerStatistics.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about throw an StatisticsClassException like the BooleanStatistics

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

Copy link
Contributor Author

@jt2594838 jt2594838 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check

@jt2594838 jt2594838 merged commit 268b323 into develop Jan 17, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants