Fix tag empty error and disorder timestamp. #489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColinLeeo
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #489 +/- ##
===========================================
+ Coverage 65.70% 65.77% +0.06%
===========================================
Files 566 566
Lines 33360 33430 +70
Branches 4664 4688 +24
===========================================
+ Hits 21919 21987 +68
- Misses 10789 10790 +1
- Partials 652 653 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jt2594838
approved these changes
May 12, 2025
Comment on lines
201
to
216
| for (int32_t pos : id_column_context.pos_in_result_) { | ||
| common::String device_id( | ||
| device_query_task_->get_device_id()->get_segments().at( | ||
| id_column_context.pos_in_device_id_)); | ||
| common::String device_id; | ||
| if (device_query_task_->get_device_id()->segment_num() <= | ||
| id_column_context.pos_in_device_id_) { | ||
| device_id = common::String(""); | ||
| } else { | ||
| device_id = common::String( | ||
| device_query_task_->get_device_id()->get_segments().at( | ||
| id_column_context.pos_in_device_id_)); | ||
| } | ||
| if (RET_FAIL(col_appenders_[pos + 1]->fill( | ||
| (char*)&device_id, sizeof(device_id), | ||
| current_block_->get_row_count()))) { |
There was a problem hiding this comment.
We should distinguish null from empty string.
("table1", null, "tag1") is different from ("table1", "", "tag1")
ColinLeeo
force-pushed
the
colin_fix_tag_empty
branch
from
3b74e14 to
c40d043
Compare
jt2594838
reviewed
Jun 18, 2025
| write_var_int(storage::NO_STR_TO_READ, out); | ||
| return ret; | ||
| } | ||
| size_t str_len = std::strlen(str); |
There was a problem hiding this comment.
It is not guaranteed that a tag will not contain '\0', so it is invalid to use std::strlen.
cpp/src/common/device_id.h
Outdated
| virtual const std::vector<std::string>& get_segments() const { | ||
| virtual const std::vector<char*>& get_segments() const { |
There was a problem hiding this comment.
As stated, C-style strings may have a potential problem.
How about using std::string*?
jt2594838
approved these changes
Jun 18, 2025
Comment on lines
1083
to
1084
| char *tmp_buf = static_cast<char *>(malloc(len + 1)); | ||
| tmp_buf[len] = '\0'; |
There was a problem hiding this comment.
Is adding '\0' still necessary?
jt2594838
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pr:
Fixed the issue of out-of-order data writes.
Fixed the issue related to writing and reading with empty tags.
Added support for writing null tag values.