Skip to content

fix read from iotdb data. #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025
Merged

fix read from iotdb data. #520

merged 1 commit into from
Jun 20, 2025

Conversation

ColinLeeo
Copy link
Contributor

@ColinLeeo ColinLeeo commented Jun 19, 2025

In IoTDB, the generated TsFile sets the encryptKey to null, but this case was not handled in the C++ implementation, resulting in a failure to read the data. This PR fixes the issue.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Project coverage is 65.79%. Comparing base (caa77ac) to head (a138b43).

Files with missing lines Patch % Lines
cpp/src/common/tsfile_common.h 60.00% 2 Missing ⚠️
cpp/src/common/tsfile_common.cc 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #520   +/-   ##
========================================
  Coverage    65.79%   65.79%           
========================================
  Files          566      566           
  Lines        33441    33446    +5     
  Branches      4691     4687    -4     
========================================
+ Hits         22002    22006    +4     
- Misses       10788    10789    +1     
  Partials       651      651           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ColinLeeo ColinLeeo requested review from jt2594838 and 761417898 and removed request for jt2594838 June 19, 2025 16:04
@jt2594838 jt2594838 merged commit 58fa12f into develop Jun 20, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants