Issue #430: Resolving type system imports through sp is slows things down too much #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…own too much - Clean up ClassLoaderUtils a bit - Added missing since version to deprecation - Consolidate redundant code inside RelativePathResolver_impl
…own too much - Allow UimaBndPlugin to dive into transitive imports and process them as well
…own too much - Make transitive import resoving optional - Added more debug logging
…em-imports-through-SPIs-slows-things-down-too-much * release/3.6.x: Issue #431: Issue using SPI-enabled type systems embedded into PEARs Issue #431: Issue using SPI-enabled type systems embedded into PEARs Issue #431: Issue using SPI-enabled type systems embedded into PEARs Issue #431: Issue using SPI-enabled type systems embedded into PEARs Issue #431: Issue using SPI-enabled type systems embedded into PEARs Issue #431: Issue using SPI-enabled type systems embedded into PEARs
…em-imports-through-SPIs-slows-things-down-too-much * release/3.6.x: Issue #431: Issue using SPI-enabled type systems embedded into PEARs
…into refactoring/430-Resolving-type-system-imports-through-SPIs-slows-things-down-too-much * refactoring/435-Improve-performance-of-ImportResolver: Issue #435: Improve performance of ImportResolver Issue #435: Improve performance of ImportResolver Issue #435: Improve performance of ImportResolver Issue #435: Improve performance of ImportResolver Issue #435: Improve performance of ImportResolver Issue #435: Improve performance of ImportResolver % Conflicts: % uimaj-core/src/main/java/org/apache/uima/resource/impl/RelativePathResolver_impl.java
…em-imports-through-SPIs-slows-things-down-too-much * release/3.6.x: Issue #435: Improve performance of ImportResolver
There was a problem hiding this comment.
Pull Request Overview
This PR addresses performance issues with type system imports by optimizing import resolution and adding configurable transitive import processing. The changes focus on reducing redundant processing and providing better control over import depth.
Key changes:
- Enhanced UimaBndPlugin to support transitive import processing with optional depth control
- Consolidated redundant ClassLoader resolution logic in ClassLoaderUtils
- Added proper deprecation annotations with version information
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ResourceManager_impl.java | Added missing deprecation version annotation |
| RelativePathResolver.java | Added deprecation version and updated implementation |
| RelativePathResolver_impl.java | Moved ClassLoader assignment and removed redundant javadoc |
| ClassLoaderUtils.java | Consolidated duplicate ClassLoader resolution logic |
| GenerateDescriptorsMojo.java | Minor code modernization using var |
| UimaBndPlugin.java | Major enhancement adding transitive import support and configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
uima-bnd-plugin/src/main/java/org/apache/uima/tools/bnd/UimaBndPlugin.java
Outdated
Show resolved
Hide resolved
uima-bnd-plugin/src/main/java/org/apache/uima/tools/bnd/UimaBndPlugin.java
Outdated
Show resolved
Hide resolved
…down too much - Cleaning up
2 tasks
reckart
deleted the
refactoring/430-Resolving-type-system-imports-through-SPIs-slows-things-down-too-much
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in the PR
How to test manually
Automatic testing
Documentation
Organizational
Only dependencies under approved licenses are allowed. LICENSE and NOTICE files in the respective modules where dependencies have been added as well as in the project root have been updated.