[#289] feat(operator): Support annotations #1817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@advancedxy Could you help me review this pull request? |
advancedxy
reviewed
Jun 25, 2024
Comment on lines
215
to
223
| for key, value := range reservedAnnotations { | ||
| annotations[key] = value | ||
| } | ||
|
|
||
| for key, value := range rss.Spec.ShuffleServer.Annotations { | ||
| if _, exist := reservedAnnotations[key]; !exist { | ||
| annotations[key] = value | ||
| } | ||
| } |
There was a problem hiding this comment.
Nit: it might be clearer to override by reservedAnnotations, such as:
for key, value := range rss.Spec.ShuffleServer.Annotations {
annotations[key] = value
}
// reserved annotations have higher preference.
for key, value := range reservedAnnotations {
annotations[key] = value
}
Comment on lines
164
to
167
| testAnnotations = map[string]string{ | ||
| "key1": "value1", | ||
| "key2": "value2", | ||
| } |
There was a problem hiding this comment.
could we also add a test case with reserved one, so that we can make sure the override logic is correct.
advancedxy
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Previous pull request is #467
I address the comments and add the uts.
Why are the changes needed?
Fix: #289
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT and run the operator in the GKE.