[#1826] fix(build): Fix multiple '--without' options and correct Hadoop profile usage #1827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t Hadoop profile usage
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1827 +/- ##
============================================
- Coverage 53.53% 53.19% -0.35%
- Complexity 2356 2844 +488
============================================
Files 368 431 +63
Lines 16852 22806 +5954
Branches 1540 2134 +594
============================================
+ Hits 9022 12132 +3110
- Misses 7303 9902 +2599
- Partials 527 772 +245 ☔ View full report in Codecov by Sentry. |
Test Results 2 640 files - 1 2 640 suites - 1 5h 27m 11s ⏱️ -59s For more details on these failures, see this check. Results for commit 19332d0. ± Comparison against base commit 1482804. ♻️ This comment has been updated with latest results. |
zuston
reviewed
Jun 25, 2024
| @@ -81,22 +81,28 @@ while (( "$#" )); do | |||
| ;; | |||
| --without-mr) | |||
| WITH_MR="false" | |||
| shift | |||
There was a problem hiding this comment.
These shift is needn't. Please to revert this.
rickyma
added a commit
that referenced
this pull request
Jun 25, 2024
…ion in build_distribution.sh (#1830) ### What changes were proposed in this pull request? Revert the incorrect shift shell statements deletion in #1827. ### Why are the changes needed? A follow-up PR for #1827. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing UTs.
zhengchenyu
pushed a commit
that referenced
this pull request
Aug 2, 2024
…op profile usage (#1827) ### What changes were proposed in this pull request? Fix two compilation issues: 1) Ineffectiveness of specifying multiple `--without` options. 2) Correct Hadoop profile not being used despite being specified, with default profile being used instead. ### Why are the changes needed? For: #1826. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing UTs.
zhengchenyu
pushed a commit
that referenced
this pull request
Aug 2, 2024
…ion in build_distribution.sh (#1830) ### What changes were proposed in this pull request? Revert the incorrect shift shell statements deletion in #1827. ### Why are the changes needed? A follow-up PR for #1827. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing UTs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix two compilation issues:
--withoutoptions.Why are the changes needed?
For: #1826.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing UTs.