Skip to content

[MINOR] fix(test): Use standard way to set storage basePath in RepartitionWithHadoopHybridStorageRssTest #1829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

wForget
Copy link
Member

@wForget wForget commented Jun 25, 2024

What changes were proposed in this pull request?

Correct rss storage basePath configuration

Why are the changes needed?

rss.storage.basePath should be configured as separated path list.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Fixed test case

@zuston zuston changed the title [MINOR] fix(test): Correct rss storage basePath configuration in RepartitionWithHadoopHybridStorageRssTest [MINOR] fix(test): Use standard way to set storage basePath in RepartitionWithHadoopHybridStorageRssTest Jun 25, 2024
@zuston zuston merged commit 1dc833f into apache:master Jun 25, 2024
41 checks passed
@zuston
Copy link
Member

zuston commented Jun 25, 2024

Merged. But I want to correct that this PR is not a correct but an improvement, as the multi paths could be specified by the format of '/data1,/data2'

@wForget
Copy link
Member Author

wForget commented Jun 25, 2024

as the multi paths could be specified by the format of '/data1,/data2'

That should use serverConf.setString instead of serverConf.set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants