[MINOR] feat(CI): Introducing surefire.rerunFailingTestsCount to identify Flakes tests.#1865
Open
zhengchenyu wants to merge 1 commit intoapache:masterfrom
Open
[MINOR] feat(CI): Introducing surefire.rerunFailingTestsCount to identify Flakes tests.#1865zhengchenyu wants to merge 1 commit intoapache:masterfrom
zhengchenyu wants to merge 1 commit intoapache:masterfrom
Conversation
…tify Flakes tests
Collaborator
Author
|
@jerqi @zuston Do you think we need to introduce rerunFailingTestsCount? |
Contributor
|
This will cause issues to be hidden. We need to find out the flaky tests and fix them. This is what UTs should do. |
Collaborator
Author
|
In fact, flaky test will not be hidden, they will show in logs. Here are hadoop test log: For now, when the some test failed, we will manually confirm whether it is flaky. If it is flaky, we still merged to master. |
Contributor
|
If all the tests finally pass, who will still check the logs and look for the flaky tests? I'm not sure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We can find many flaky test, it is not conducive to review code.
We can introduce surefire.rerunFailingTestsCount=2, the test is considered failed when it fails three times, or Flaskes.