Skip to content

[#2472] feat(spark): Add an rpc method to obtain the uniffleId and delete the Write Stage for retry at the same time. #2473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[#2472] feat(spark): Add an rpc method to obtain the uniffleId and delete the Write Stage for retry at the same time. #2473

wants to merge 2 commits into from
+538 −1,704

Conversation

yl09099
Copy link
Contributor

@yl09099 yl09099 commented May 5, 2025 •
edited
Loading

What changes were proposed in this pull request?

Add an RPC method for obtaining the uniffleShuffleId and delete the relevant code for retrying the Write Stage.

Why are the changes needed?

Fix: #2470
Fix: #2472

Does this PR introduce any user-facing change?

No.

How was this patch tested?

UT.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2025 •
edited
Loading

Test Results

 2 999 files   - 20   2 999 suites   - 20   6h 41m 2s ⏱️ - 5m 35s
 1 169 tests  -  9   1 168 ✅  -  9   1 💤 ±0  0 ❌ ±0 
14 890 runs   - 32  14 875 ✅  - 32  15 💤 ±0  0 ❌ ±0 

Results for commit 307b8f2. ± Comparison against base commit 057dcd2.

This pull request removes 9 tests. 
org.apache.hadoop.mapred.SortWriteBufferManagerTest ‑ testCombineBuffer
org.apache.hadoop.mapred.SortWriteBufferManagerTest ‑ testCommitBlocksWhenMemoryShuffleDisabled
org.apache.hadoop.mapred.SortWriteBufferManagerTest ‑ testOnePartition
org.apache.hadoop.mapred.SortWriteBufferManagerTest ‑ testWriteException
org.apache.hadoop.mapred.SortWriteBufferManagerTest ‑ testWriteNormal
org.apache.hadoop.mapred.SortWriteBufferManagerTest ‑ testWriteNormalWithRemoteMerge
org.apache.hadoop.mapred.SortWriteBufferManagerTest ‑ testWriteNormalWithRemoteMergeAndCombine
org.apache.uniffle.test.RSSStageDynamicServerReWriteTest ‑ testRSSStageResubmit
org.apache.uniffle.test.ReassignAndStageRetryTest ‑ resultCompareTest

♻️ This comment has been updated with latest results.

@zuston zuston changed the title [FEATURE] Add an rpc method to obtain the uniffleId and delete the Write Stage for retry at the same time. [#2472] feat(spark): Add an rpc method to obtain the uniffleId and delete the Write Stage for retry at the same time. May 6, 2025
@zuston zuston changed the title [#2472] feat(spark): Add an rpc method to obtain the uniffleId and delete the Write Stage for retry at the same time. [#2474] feat(spark): Add an rpc method to obtain the uniffleId and delete the Write Stage for retry at the same time. May 6, 2025
@yl09099
[apache#2474] feat(spark): Add an rpc method to obtain the uniffleId …
307b8f2 
…and delete the Write Stage for retry at the same time.
@yl09099 yl09099 changed the title [#2474] feat(spark): Add an rpc method to obtain the uniffleId and delete the Write Stage for retry at the same time. [#2472] feat(spark): Add an rpc method to obtain the uniffleId and delete the Write Stage for retry at the same time. May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@yl09099