Skip to content

[#2472] feat(spark): Add an rpc method to obtain the uniffleId and delete the Write Stage for retry at the same time. #2473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[#2472] feat(spark): Add an rpc method to obtain the uniffleId and delete the Write Stage for retry at the same time. #2473

wants to merge 2 commits into from

Conversation

yl09099
Copy link
Contributor

@yl09099 yl09099 commented May 5, 2025 •
edited
Loading

What changes were proposed in this pull request?

Add an RPC method for obtaining the uniffleShuffleId and delete the relevant code for retrying the Write Stage.

Why are the changes needed?

Design doc:
https://docs.google.com/document/d/1TPxg4CUNklg26-JIcKCeIDwZb9lWKj3mIu-qjMcj0wU/edit?usp=sharing

Fix: #2470
Fix: #2472

Does this PR introduce any user-facing change?

No.

How was this patch tested?

UT.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2025 •
edited
Loading

Test Results

 2 999 files   - 20   2 999 suites   - 20   6h 40m 18s ⏱️ - 6m 19s
 1 169 tests  -  9   1 168 ✅  -  9   1 💤 ±0  0 ❌ ±0 
14 890 runs   - 32  14 875 ✅  - 32  15 💤 ±0  0 ❌ ±0 

Results for commit 6efc618. ± Comparison against base commit 057dcd2.

This pull request removes 9 tests. 
org.apache.hadoop.mapred.SortWriteBufferManagerTest ‑ testCombineBuffer
org.apache.hadoop.mapred.SortWriteBufferManagerTest ‑ testCommitBlocksWhenMemoryShuffleDisabled
org.apache.hadoop.mapred.SortWriteBufferManagerTest ‑ testOnePartition
org.apache.hadoop.mapred.SortWriteBufferManagerTest ‑ testWriteException
org.apache.hadoop.mapred.SortWriteBufferManagerTest ‑ testWriteNormal
org.apache.hadoop.mapred.SortWriteBufferManagerTest ‑ testWriteNormalWithRemoteMerge
org.apache.hadoop.mapred.SortWriteBufferManagerTest ‑ testWriteNormalWithRemoteMergeAndCombine
org.apache.uniffle.test.RSSStageDynamicServerReWriteTest ‑ testRSSStageResubmit
org.apache.uniffle.test.ReassignAndStageRetryTest ‑ resultCompareTest

♻️ This comment has been updated with latest results.

@zuston zuston changed the title [FEATURE] Add an rpc method to obtain the uniffleId and delete the Write Stage for retry at the same time. [#2472] feat(spark): Add an rpc method to obtain the uniffleId and delete the Write Stage for retry at the same time. May 6, 2025
@zuston zuston changed the title [#2472] feat(spark): Add an rpc method to obtain the uniffleId and delete the Write Stage for retry at the same time. [#2474] feat(spark): Add an rpc method to obtain the uniffleId and delete the Write Stage for retry at the same time. May 6, 2025
@yl09099 yl09099 changed the title [#2474] feat(spark): Add an rpc method to obtain the uniffleId and delete the Write Stage for retry at the same time. [#2472] feat(spark): Add an rpc method to obtain the uniffleId and delete the Write Stage for retry at the same time. May 6, 2025
@yl09099 yl09099 force-pushed the uniffle-2472 branch 3 times, most recently from f867b70 to adb41bc Compare May 6, 2025 08:54
@yl09099 yl09099 requested a review from zuston May 6, 2025 09:25
@yl09099 yl09099 force-pushed the uniffle-2472 branch 4 times, most recently from 4f1b78e to fa69421 Compare May 7, 2025 07:00
@yl09099
[apache#2472] feat(spark): Add an rpc method to obtain the uniffleId …
6efc618 
…and delete the Write Stage for retry at the same time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zuston zuston Awaiting requested review from zuston

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@yl09099