[#2460] feat(spark3): Add client/uniffle different observed shuffle speed #2500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerqi
reviewed
Jun 12, 2025
| roundToTwoDecimals(aggTaskInfo.shuffleBytes.toDouble / aggTaskInfo.shuffleWriteMillis / 1000) | ||
| } | ||
| val clientObservedReadAvgSpeed = if (aggTaskInfo.shuffleReadMillis == 0) 0 else { | ||
| roundToTwoDecimals(aggTaskInfo.shuffleBytes.toDouble / aggTaskInfo.shuffleReadMillis / 1000) |
There was a problem hiding this comment.
Has the time excluded computation time?
There was a problem hiding this comment.
Yes. This is aligned with the spark's shuffle write metrics
jerqi
approved these changes
Jun 12, 2025
zuston
added a commit
to zuston/incubator-uniffle
that referenced
this pull request
Jun 17, 2025
…ffle speed (apache#2500) ### What changes were proposed in this pull request? Add client/uniffle different observed shuffle speed  ### Why are the changes needed? followup apache#2460 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Neen't
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add client/uniffle different observed shuffle speed
Why are the changes needed?
followup #2460
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Neen't