Skip to content

[#2503] fix(spark): Skip reassignment number check on partition split #2504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025

Conversation

zuston
Copy link
Member

@zuston zuston commented Jun 16, 2025

What changes were proposed in this pull request?

Skip reassignment number check on partition split and reuse the assigned server for split partition

Why are the changes needed?

fix #2503

image

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Internal job test

Copy link

Test Results

 3 049 files  ±0   3 049 suites  ±0   6h 47m 26s ⏱️ - 1m 0s
 1 186 tests ±0   1 185 ✅ ±0   1 💤 ±0  0 ❌ ±0 
15 042 runs  ±0  15 027 ✅ ±0  15 💤 ±0  0 ❌ ±0 

Results for commit d0585ca. ± Comparison against base commit 575eee0.

@jerqi jerqi requested a review from yl09099 June 19, 2025 03:25
@zuston
Copy link
Member Author

zuston commented Jun 24, 2025

Gentle ping @yl09099 @jerqi .

@yl09099
Copy link
Contributor

yl09099 commented Jun 25, 2025

LGTM.

@yl09099 yl09099 merged commit 69b2d51 into apache:master Jun 26, 2025
41 checks passed
@yl09099
Copy link
Contributor

yl09099 commented Jun 26, 2025

@zuston Thank you for sharing.
@jerqi Thank you for your review.

zuston added a commit to zuston/incubator-uniffle that referenced this pull request Jul 2, 2025
… split (apache#2504)

Merge pull request apache#2504 from zuston/reassinBug

[Bug] Incorrect reassignment server number for partition split (Closes apache#2503)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Incorrect reassignment server number for partition split
2 participants