[#2508] feat(spark3): Record failed tasks on any shuffle write/failure into event logs #2509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…failure into event logs
3 tasks
jerqi
reviewed
Jun 19, 2025
proto/src/main/proto/Rss.proto
Outdated
| @@ -636,6 +638,8 @@ message ReportShuffleReadMetricRequest { | |||
| int32 stageId = 2; | |||
| int64 taskId = 3; | |||
| map<string, ShuffleReadMetric> metrics = 4; | |||
| bool isShuffleReadFailed = 6; | |||
There was a problem hiding this comment.
Could u remove shuffle and why this is 6 instead of 5?
There was a problem hiding this comment.
Could u remove
shuffleand why this is 6 instead of 5?
Mistake.
Is this a boolean or enum?
boolean
jerqi
reviewed
Jun 19, 2025
proto/src/main/proto/Rss.proto
Outdated
| @@ -636,6 +638,8 @@ message ReportShuffleReadMetricRequest { | |||
| int32 stageId = 2; | |||
| int64 taskId = 3; | |||
| map<string, ShuffleReadMetric> metrics = 4; | |||
| bool isShuffleReadFailed = 5; | |||
There was a problem hiding this comment.
Could you remove shuffle from the variable name? Because the message already has the shuffle.
There was a problem hiding this comment.
How about changing this to isTaskReadFailed ?
There was a problem hiding this comment.
isReadFailed may be enough. isTaskReadFailed is ok if this fail will cause the failure of the task.
There was a problem hiding this comment.
isTaskReadFailed is ok if this fail will cause the failure of the task.
It will
|
Update @jerqi |
jerqi
approved these changes
Jun 24, 2025
zuston
added a commit
to zuston/incubator-uniffle
that referenced
this pull request
Jul 2, 2025
…failure into event logs (apache#2509) Record failed tasks on any shuffle write/failure into event logs For apache#2508. Having this PR, we could retrieve spark jobs failure reason from the whole clusters' event logs. No. Neen't
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Record failed tasks on any shuffle write/failure into event logs
Why are the changes needed?
For #2508. Having this PR, we could retrieve spark jobs failure reason from the whole clusters' event logs.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Neen't