[#2518] fix(client): Disable fast fail on any pushing failure if partition reassign is activated #2519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f partition reassign is activated
jerqi
approved these changes
Jun 24, 2025
3 tasks
zuston
added a commit
to zuston/incubator-uniffle
that referenced
this pull request
Jul 2, 2025
…f partition reassign is activated (apache#2519) ### What changes were proposed in this pull request? Disable fast fail on any pushing failure if partition reassign is activated ### Why are the changes needed? Before this PR, if multi-replica is disabled, the sending logic would fail fast upon any push failure. However, when partition reassignment is enabled, this behavior could cause some block futures to be canceled, leading to the loss of block sending events. As a result, the client might fail due to unsent remaining blocks. for apache#2518 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Needn't. This could be quickly validated by human.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Disable fast fail on any pushing failure if partition reassign is activated
Why are the changes needed?
Before this PR, if multi-replica is disabled, the sending logic would fail fast upon any push failure.
However, when partition reassignment is enabled, this behavior could cause some block futures to be canceled, leading to the loss of block sending events.
As a result, the client might fail due to unsent remaining blocks.
for #2518
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Needn't. This could be quickly validated by human.