Skip to content

[#2496] improvement(server): Use tryLock instead of synchronized on buffer flushing #2524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2025
Merged

[#2496] improvement(server): Use tryLock instead of synchronized on buffer flushing #2524

merged 1 commit into from
Jun 30, 2025

Conversation

xianjingfeng
Copy link
Member

@xianjingfeng xianjingfeng commented Jun 27, 2025 •
edited by zuston
Loading

What changes were proposed in this pull request?

Use tryLock instead of synchronized when flush buffer

Why are the changes needed?

To followup the #2523 for better performance, this optimization is mentioned in #2523 (comment)

Does this PR introduce any user-facing change?

No.

How was this patch tested?

CI

@xianjingfeng xianjingfeng requested a review from zuston June 27, 2025 02:35
@zuston zuston changed the title [MINOR] improvement(server): use tryLock instead of synchronized when flush buffer [#2496] improvement(server): use tryLock instead of synchronized when flush buffer Jun 27, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 27, 2025 •
edited
Loading

Test Results

 3 049 files  ±0   3 049 suites  ±0   6h 47m 44s ⏱️ +7s
 1 188 tests ±0   1 187 ✅ ±0   1 💤 ±0  0 ❌ ±0 
15 067 runs  ±0  15 052 ✅ ±0  15 💤 ±0  0 ❌ ±0 

Results for commit d09faec. ± Comparison against base commit 887d042.

♻️ This comment has been updated with latest results.

@zuston zuston changed the title [#2496] improvement(server): use tryLock instead of synchronized when flush buffer [#2496] improvement(server): Use tryLock instead of synchronized on buffer flushing Jun 27, 2025
zuston
zuston approved these changes Jun 27, 2025
View reviewed changes
Copy link
Member

@zuston zuston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks for doing this. And I updated the title and the description

@xianjingfeng xianjingfeng merged commit ad7babb into apache:master Jun 30, 2025
80 of 81 checks passed
@xianjingfeng
Copy link
Member Author

Thanks for your review. @zuston

@xianjingfeng xianjingfeng deleted the minor branch June 30, 2025 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zuston zuston zuston approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xianjingfeng @zuston