Skip to content

[#2494] feat(client): Introduce codec statistics to measure de/compression performance #2528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 27, 2025

Conversation

zuston
Copy link
Member

@zuston zuston commented Jun 27, 2025

What changes were proposed in this pull request?

Introduce codec statistics to measure de/compression performance.

image

Why are the changes needed?

The subtask of #2494

Does this PR introduce any user-facing change?

rss.client.io.compression.statisticsEnabled = false

How was this patch tested?

Neen't

Copy link

github-actions bot commented Jun 27, 2025

Test Results

 3 049 files  ±0   3 049 suites  ±0   6h 47m 53s ⏱️ +16s
 1 188 tests ±0   1 187 ✅ ±0   1 💤 ±0  0 ❌ ±0 
15 067 runs  ±0  15 052 ✅ ±0  15 💤 ±0  0 ❌ ±0 

Results for commit 0f59c84. ± Comparison against base commit 887d042.

♻️ This comment has been updated with latest results.

@zuston
Copy link
Member Author

zuston commented Jun 27, 2025

This is the first step to improve compression performance. cc @jerqi

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zuston zuston merged commit 80aa170 into apache:master Jun 27, 2025
40 of 41 checks passed
@zuston zuston deleted the compressionStat branch June 27, 2025 07:07
zuston added a commit to zuston/incubator-uniffle that referenced this pull request Jul 2, 2025
…compression performance (apache#2528)

### What changes were proposed in this pull request?

Introduce codec statistics to measure de/compression performance.

![image](https://github.com/user-attachments/assets/bfe9d698-fd51-4187-9b9f-24a9413bb4f7)

### Why are the changes needed?

The subtask of apache#2494

### Does this PR introduce _any_ user-facing change?

`rss.client.io.compression.statisticsEnabled = false`

### How was this patch tested?

Neen't
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants