[#2529] fix(spark3): Incorrect clientInfo without nettyPort if netty is enabled #2530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a UT for this if this is a fix? |
I really want to add UTs but it's hard to simulate |
|
You just need to add a UT to test constructor of |
Aha. It's easy but not effective. And this have been tested in current codebase |
jerqi
approved these changes
Jun 27, 2025
|
Thanks @jerqi . Merged. |
zuston
added a commit
to zuston/incubator-uniffle
that referenced
this pull request
Jul 2, 2025
…netty is enabled (apache#2530) ### What changes were proposed in this pull request? If the shuffle server enables Netty RPC, clients collect push cost metrics along with client information. However, the collected shuffle server information lacks the Netty port, which causes subsequent analysis to be inaccurate or invalid. ### Why are the changes needed? for apache#2529  ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Yes. Test in the internal cluster spark jobs and existing UTs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
If the shuffle server enables Netty RPC, clients collect push cost metrics along with client information. However, the collected shuffle server information lacks the Netty port, which causes subsequent analysis to be inaccurate or invalid.
Why are the changes needed?
for #2529
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Yes. Test in the internal cluster spark jobs and existing UTs