[#2526] improvement: Reset the chunkID if it overflow #2531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -126,6 +126,13 @@ Chunk getChunk(int size) { | |||
| private Chunk createChunk(boolean pool, int size) { | |||
| Chunk chunk; | |||
| int id = chunkID.getAndIncrement(); | |||
| // if chunkID overflow | |||
| if (id <= 0) { | |||
| int maxChunkId = chunkIdMap.keySet().stream().mapToInt(Integer::intValue).max().orElse(0); | |||
There was a problem hiding this comment.
chunkIdMap contains the chunk not in the chunk pool. Besides this is not thread-safe.
There was a problem hiding this comment.
We can add a variable to record the maximum chunk id in the chunk pool.
There was a problem hiding this comment.
@xianjingfeng, updated the code
xianjingfeng
reviewed
Jul 1, 2025
server/src/main/java/org/apache/uniffle/server/buffer/lab/ChunkCreator.java
Outdated
Show resolved
Hide resolved
xianjingfeng
reviewed
Jul 1, 2025
server/src/main/java/org/apache/uniffle/server/buffer/lab/ChunkCreator.java
Outdated
Show resolved
Hide resolved
…kCreator.java Co-authored-by: xianjingfeng <[email protected]>
…kCreator.java Co-authored-by: xianjingfeng <[email protected]>
xianjingfeng
approved these changes
Jul 2, 2025
xianjingfeng
changed the title
|
Merged. Thanks for your contribution. @OmarBustamante |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
If the chunId overflow it will reset it to (max chunk id in the chunk pool + 1)
Why are the changes needed?
Fix: #2526 Handle the possible overflow of the chunkId
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit test