Skip to content

[#2536] feat(spark): Controllable concurrency for overlapping compression#2541

Merged
zuston merged 2 commits intoapache:masterfrom
zuston:compressionConcurrency
Jul 10, 2025
Merged

[#2536] feat(spark): Controllable concurrency for overlapping compression#2541
zuston merged 2 commits intoapache:masterfrom
zuston:compressionConcurrency

Conversation

@zuston
Copy link
Member

@zuston zuston commented Jul 8, 2025

What changes were proposed in this pull request?

Introduce extra the option to control the concurrency of overlapping compression.

Why are the changes needed?

for #2536 .

Decoupling compression concurrency from the transfer pool is essential for resource isolation and performance stability, especially under multi-tenant or CPU-constrained environments.

Does this PR introduce any user-facing change?

Yes.

rss.client.write.overlappingCompressionThreads=-1.

About overlapping compression related config options, I will add it into doc in another PR

How was this patch tested?

Unit tests.

@zuston zuston requested a review from roryqi July 8, 2025 07:48
@github-actions
Copy link

github-actions bot commented Jul 8, 2025

Test Results

 3 082 files  +10   3 082 suites  +10   6h 48m 27s ⏱️ -13s
 1 191 tests + 1   1 190 ✅ + 1   1 💤 ±0  0 ❌ ±0 
15 100 runs  +10  15 085 ✅ +10  15 💤 ±0  0 ❌ ±0 

Results for commit aa01390. ± Comparison against base commit 77e6ab1.

♻️ This comment has been updated with latest results.

@zuston zuston linked an issue Jul 8, 2025 that may be closed by this pull request
3 tasks
@zuston
Copy link
Member Author

zuston commented Jul 9, 2025

cc @jerqi

Copy link
Contributor

@roryqi roryqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zuston zuston merged commit f1323ab into apache:master Jul 10, 2025
41 checks passed
@zuston zuston deleted the compressionConcurrency branch July 10, 2025 03:05
@zuston
Copy link
Member Author

zuston commented Jul 10, 2025

Merged.

zuston added a commit to zuston/incubator-uniffle that referenced this pull request Sep 23, 2025
…ompression (apache#2541)

### What changes were proposed in this pull request?

Introduce extra the option to control the concurrency of overlapping compression.

### Why are the changes needed?

for apache#2536 .

Decoupling compression concurrency from the transfer pool is essential for resource isolation and performance stability, especially under multi-tenant or CPU-constrained environments.

### Does this PR introduce _any_ user-facing change?

Yes.

`rss.client.write.overlappingCompressionThreads=-1`.

About overlapping compression related config options, I will add it into doc in another PR

### How was this patch tested?

Unit tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Limited concurrency for overlapping compression

2 participants