Skip to content

[#2525][FOLLOWUP] fix(server): remove metric buffer_block_size #2567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2025

Conversation

xianjingfeng
Copy link
Member

@xianjingfeng xianjingfeng commented Jul 31, 2025

What changes were proposed in this pull request?

Remove metric buffer_block_size

Why are the changes needed?

The observations of Summary are expensive due to the streaming quantile calculation and synchronized is used in Summary.observe.

"epollEventLoopGroup-3-130" #341 prio=10 os_prio=0 cpu=51979.29ms elapsed=2103.78s tid=0x000004c0882e7000 nid=0x486d waiting for monitor entry  [0x00007f21769e7000]
   java.lang.Thread.State: BLOCKED (on object monitor)
        at io.prometheus.client.TimeWindowQuantiles.insert(TimeWindowQuantiles.java:36)
        - waiting to lock <0x00000003006a7df8> (a io.prometheus.client.TimeWindowQuantiles)
        at io.prometheus.client.Summary$Child.observe(Summary.java:283)
        at io.prometheus.client.Summary.observe(Summary.java:309)

Does this PR introduce any user-facing change?

No.

How was this patch tested?

CI

@xianjingfeng xianjingfeng requested a review from zuston July 31, 2025 03:15
Copy link

Test Results

 3 082 files  ±0   3 082 suites  ±0   6h 49m 33s ⏱️ + 1m 49s
 1 193 tests ±0   1 192 ✅ ±0   1 💤 ±0  0 ❌ ±0 
15 123 runs  ±0  15 108 ✅ ±0  15 💤 ±0  0 ❌ ±0 

Results for commit b7391b7. ± Comparison against base commit 066e71e.

Copy link
Member

@zuston zuston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zuston zuston changed the title [#2525][FOLLOWUP] remove metric buffer_block_size [#2525][FOLLOWUP] fix(server): remove metric buffer_block_size Jul 31, 2025
@xianjingfeng xianjingfeng merged commit 99d5c3a into apache:master Aug 4, 2025
41 checks passed
@xianjingfeng xianjingfeng deleted the issue_2525_followup branch August 4, 2025 03:19
@xianjingfeng
Copy link
Member Author

@zuston Thanks for your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants