Skip to content

[#2571] fix(client): Race condition when adding shuffle servers #2574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 5, 2025

Conversation

zuston
Copy link
Member

@zuston zuston commented Aug 5, 2025

What changes were proposed in this pull request?

Using the thread safe way to add shuffle-servers to emlinate race condition

Why are the changes needed?

fix #2571

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Needn't

Copy link

github-actions bot commented Aug 5, 2025

Test Results

 3 082 files  ±0   3 082 suites  ±0   6h 49m 26s ⏱️ -31s
 1 193 tests ±0   1 192 ✅ ±0   1 💤 ±0  0 ❌ ±0 
15 123 runs  ±0  15 108 ✅ ±0  15 💤 ±0  0 ❌ ±0 

Results for commit a2c9b1a. ± Comparison against base commit 7414ed5.

@zuston zuston requested a review from xianjingfeng August 5, 2025 08:36
Copy link
Member

@xianjingfeng xianjingfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zuston zuston merged commit 4eb83ee into apache:master Aug 5, 2025
41 checks passed
@zuston zuston deleted the addServers branch August 5, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Race condition when adding shuffle servers in ShuffleWriteClientImpl
2 participants