Skip to content

FOP-2865: stroke-opacity is not honored on svg:text while conveting svg to pdf #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

FOP-2865: stroke-opacity is not honored on svg:text while conveting svg to pdf #64

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e871c98
FOP-2865: stroke-opacity is not honored on svg:text while conveting s…
Vazid546 Oct 2, 2020
07d912e
Merge pull request #1 from Vazid546/Fop
Vazid546 Oct 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion fop-core/src/main/java/org/apache/fop/svg/PDFTextPainter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ private void applyColorAndPaint(TextPaintInfo tpi) {
Paint strokePaint = tpi.strokePaint;
Stroke stroke = tpi.strokeStroke;
int fillAlpha = PDFGraphics2D.OPAQUE;
int strokeAlpha = PDFGraphics2D.OPAQUE;
if (fillPaint instanceof Color) {
Color col = (Color) fillPaint;
pdf.applyColor(col, true);
Expand All @@ -175,13 +176,14 @@ private void applyColorAndPaint(TextPaintInfo tpi) {
if (strokePaint instanceof Color) {
Color col = (Color) strokePaint;
pdf.applyColor(col, false);
strokeAlpha = col.getAlpha();
}
pdf.applyPaint(fillPaint, true);
pdf.applyStroke(stroke);
if (strokePaint != null) {
pdf.applyPaint(strokePaint, false);
}
pdf.applyAlpha(fillAlpha, PDFGraphics2D.OPAQUE);
pdf.applyAlpha(fillAlpha, strokeAlpha);
}

@Override
Expand Down